-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-base]: Fix build with "mysqlplugin" feature by linking to OpenSSL and zlib #24462
[qt5-base]: Fix build with "mysqlplugin" feature by linking to OpenSSL and zlib #24462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for qt5-base but no changes to version or port version.
-- Version: 5.15.3#2
-- Old SHA: abaaa592badf33576f197d915ed1f4ddd91d0931
-- New SHA: 822bf13419cbecb5b09b28f2bbee82e207f345e3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
fecf517
to
722bb62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for qt5-base but no changes to version or port version.
-- Version: 5.15.3#3
-- Old SHA: 822bf13419cbecb5b09b28f2bbee82e207f345e3
-- New SHA: 7518c5eeb84d3bbfaaa88cb19795b693fd0923f7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
…L and zlib Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
722bb62
to
cfaa391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this PR fixed the build, the build process finished without errors, thank you 🙌 @davidebeatrici.
I don't know if the static build especially QMYSQL plugin works correctly, but I will test it in the future when I will do next release of my personal library project and let know.
No problem, thanks for testing! |
cc @Neumann-A for review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix! |
Thanks for merging! |
Thx guys for this PR |
Fixes #20817.